Try to improve bookmarks
publié le , mis à jour⚙️ Ceci est une proposition de changement de code.
Rendez-vous sur sa page Coderberg pour l'osculter.
I added some bookmarks : random + some really long name https://fr.wikipedia.org/wiki/Liste_des_toponymes_les_plus_longs
I don't know why some longest name are just displayed with short ones
Some long name was cropped like "Évry-Courcouronnes"
I only changed the CSS I only looked at the "Gérer mes favoris" page
I tried to :
- display the full name
- go to the new line when needed
- vertically center the name when there is no icon
- having a nice UI design
| Before | After |
|---|---|
etienneJr
youpi, merci pour cette (en fait pas tout à fait) première PR ! 😅
pinage404
Cette PR est une invitation à la discussion, je peux changer ce que vous voulez
On peut discuter sur Matrix si vous voulez un échange plus rapide
laem
I'm not sure about the overall gain of giving long titles the possibility to make the bubble higher. The gain of being able to read the full bookmark is appreciable, but it disorganises the grid which makes for quite a buggy impression IMHO.
Another solution I had in mind already : move the icon to the top-left corner. Like the blue arrow. This would save one line of text that would solve most problems : the remaining long bookmark names that would be cropped, like "Direction..." would still be perfectly acknowledgeable without reading the full text.
The blue arrow could go right-bottom and be a bit less visible, as it repeats on all bookmarks, it doesn't need to be so visible.